Issue 217020: Add theme promo to NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217020: Add theme promo to NTP (Closed)

Created:
11 years, 3 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org, Ben Goodger (Google), Glen Murphy

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds a theme promo in the lower right corner BUG=None TEST=The theme promo should show up in the lower right corner and when clicked should navigate to the Chrome theme gallery. The promo should go away after 5 runs of chrome Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26894

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -4 lines)			Patch
A	chrome/app/theme/ntp_themes_promo.png	View	1	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/dom_ui_theme_source.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View	1 2	2 chunks	+11 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/new_tab_theme.css	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

On 2009/09/22 21:44:18, arv wrote:
>

Expand Messages | Collapse Messages