linux: manpage update to reflect proxy-setting reality

linux: manpage update to reflect proxy-setting reality

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26865

[Mike Mammarella, 2009-09-22 19:41:02]

Sounds like reasonable text to me. Maybe we want to refer to the wiki page as
well, in case it's more up to date?
http://code.google.com/p/chromium/wiki/LinuxProxyConfig (Although looking at
that page it does not describe the command line options currently.)

http://codereview.chromium.org/217018/diff/1/2
File chrome/app/resources/manpage.1.in (right):

http://codereview.chromium.org/217018/diff/1/2#newcode79
Line 79: because Gnome/KDE proxy settings are propagated into these variables
Well, gnome settings are anyway. I might say "may be" instead of "are" here.
Maybe say "some terminals" as well?

[Evan Martin, 2009-09-22 21:40:17]

On 2009/09/22 19:41:02, Mike Mammarella wrote:
> Sounds like reasonable text to me. Maybe we want to refer to the wiki page as
> well, in case it's more up to date?
> http://code.google.com/p/chromium/wiki/LinuxProxyConfig (Although looking at
> that page it does not describe the command line options currently.)

I kinda think the sorts of scenarios where you need to tweak proxy settings you
won't have access to the internet to look at the page.

> http://codereview.chromium.org/217018/diff/1/2
> File chrome/app/resources/manpage.1.in (right):
> 
> http://codereview.chromium.org/217018/diff/1/2#newcode79
> Line 79: because Gnome/KDE proxy settings are propagated into these variables
> Well, gnome settings are anyway. I might say "may be" instead of "are" here.
> Maybe say "some terminals" as well?

Good idea.  Fixed, new version up.

[Mike Mammarella, 2009-09-22 21:44:40]

LGTM with grammar fix

http://codereview.chromium.org/217018/diff/3001/3002
File chrome/app/resources/manpage.1.in (right):

http://codereview.chromium.org/217018/diff/3001/3002#newcode79
Line 79: because Gnome/KDE proxy settings may propagated into these variables
"may propagate" or "may be propagated", pick one :)

[Evan Martin, 2009-09-22 21:47:06]

On 2009/09/22 21:44:40, Mike Mammarella wrote:
> LGTM with grammar fix

yay for code review