Issue 2161007: Expose GptData.current_kernel as an output of GptNextKernelEntry()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2161007: Expose GptData.current_kernel as an output of GptNextKernelEntry() (Closed)

Created:
10 years, 7 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
Louis, Bill Richardson

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/chromiumos

Visibility:
Public.

Description

Expose GptData.current_kernel as an output of GptNextKernelEntry() LoadKernel() needs to pass the kernel partition number out to the BIOS, so it can be passed to the bootloader.

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	src/platform/vboot_reference/cgptlib/cgptlib.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Louis

10 years, 7 months ago (2010-05-26 01:18:22 UTC) #3

LGTM. Just curious why don't we use a getter function, like GetCurrentKernel(),
to encap it, instead of direct accessing current_kernel variable?

Expand Messages | Collapse Messages