Mac: Empty bookmark bar should show IDS_BOOKMARKS_NO_ITEMS.

Mac: Empty bookmark bar should show IDS_BOOKMARKS_NO_ITEMS.

TEST=BookmarkBarControllerTest.DisplaysHelpMessageOnEmpty
TEST=BookmarkBarControllerTest.HidesHelpMessageWithBookmark
BUG=17360
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26853

[John Grabowski, 2009-09-22 20:26:35]

LGTM with one style nit.
+cc tvl as fyi on l10n stuff in nib

http://codereview.chromium.org/216052/diff/1/4
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/216052/diff/1/4#newcode587
Line 587: BOOL hidden = (node->GetChildCount() == 0) ? NO : YES;
Not clear if it matters, but perhaps we want to hide this view before adding
items to the bar?  Seems a little cleaner to put this conditional at the top.

http://codereview.chromium.org/216052/diff/1/6
File chrome/browser/cocoa/bookmark_bar_view.h (right):

http://codereview.chromium.org/216052/diff/1/6#newcode14
Line 14: IBOutlet NSTextField* no_item_textfield_;
objc naming style for members is camelCaseWithFirstLetterNotInCaps_.

[TVL, 2009-09-22 20:38:43]

http://codereview.chromium.org/216052/diff/1/4
File chrome/browser/cocoa/bookmark_bar_controller.mm (right):

http://codereview.chromium.org/216052/diff/1/4#newcode587
Line 587: BOOL hidden = (node->GetChildCount() == 0) ? NO : YES;
On 2009/09/22 20:26:36, John Grabowski wrote:
> Not clear if it matters, but perhaps we want to hide this view before adding
> items to the bar?  Seems a little cleaner to put this conditional at the top.
> 

You could also just check x_offset at then end to see if there were any buttons
added.

http://codereview.chromium.org/216052/diff/1/6
File chrome/browser/cocoa/bookmark_bar_view.h (right):

http://codereview.chromium.org/216052/diff/1/6#newcode20
Line 20: 
whitespace