Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 216050: Added a couple of TSAN suppressions (Closed)

Created:
11 years, 3 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
Reviewers:
dank
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

Added a couple of TSAN suppressions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26910

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M tools/valgrind/tsan/suppressions.txt View 1 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Timur Iskhodzhanov
11 years, 3 months ago (2009-09-22 18:28:59 UTC) #1
dank
Timur, can you please use fewer wildcards? In the memcheck suppression files, we tend to ...
11 years, 3 months ago (2009-09-22 18:45:17 UTC) #2
Timur Iskhodzhanov
With ThreadSanitizer we do the opposite. Can you please discuss it with Kostya? He convinced ...
11 years, 3 months ago (2009-09-22 18:58:31 UTC) #3
Timur Iskhodzhanov
Updated the suppression: deleted bug_21474 suppressions since the issue was fixed On 2009/09/22 18:58:31, Timur ...
11 years, 3 months ago (2009-09-22 21:17:24 UTC) #4
Timur Iskhodzhanov
Dan, Do I need to do anything else with this changelist?
11 years, 3 months ago (2009-09-23 08:05:27 UTC) #5
dank
It's tempting to say make LoadLog derive from ThreadSafeRefCounted (if that's the right fix) rather ...
11 years, 3 months ago (2009-09-23 09:34:12 UTC) #6
Timur Iskhodzhanov
11 years, 3 months ago (2009-09-23 09:39:57 UTC) #7
This is what I wanted to do, but here http://codereview.chromium.org/215011
we've decided to fix multi-threaded usage of LoadLog rather than allow it.

Powered by Google App Engine
This is Rietveld 408576698