Increase valgrind's redzone from 16 to 64 bytes....

Increase valgrind's redzone from 16 to 64 bytes.
If https://bugs.kde.org/show_bug.cgi?id=208197 is ever fixed,
we can get rid of the patch and change the redzone size
with a commandline option instead.
Install to /usr/local/valgrind-10880-redzone to make it easier to tell which machines have the updated valgrind.
Add DIRNAME variable to valgrind build script to simplify changing name of tarball/build dir/install dir.
Also give -f option to mv because macosx's mv is timid about overwriting symlinks.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26849

[dank, 2009-09-22 17:20:25]

This should be fun.

[stuartmorgan, 2009-09-22 17:38:25]

http://codereview.chromium.org/216048/diff/1/2
File tools/valgrind/build-valgrind-for-chromium.sh (right):

http://codereview.chromium.org/216048/diff/1/2#newcode51
Line 51: rm -rf $DIRNAME
All these changes removed quotes; seems dangerous for something that could cause
serious damage if a stray space ever crept in to one of the component variables.

http://codereview.chromium.org/216048/diff/1/2#newcode76
Line 76: # Make red zone 64 times bigger to catch memory corruption?
I'm pretty sure 16 -> 64 isn't 64x ;)

[stuartmorgan, 2009-09-22 18:01:09]

LGTM