Issue 216032: Because we use scoped_refptr<> to the HttpResponseInfo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216032: Because we use scoped_refptr<> to the HttpResponseInfo... (Closed)

Created:
11 years, 3 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Because we use scoped_refptr<> to the HttpResponseInfo and SSLCertRequestInfo, simply declaring the forward class definition is not enough to include this header. This header is really dependent on those two class definitions. BUG=none TEST=none

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	net/http/http_response_info.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

11 years, 3 months ago (2009-09-22 19:29:36 UTC) #2

LGTM.

I ran into this issue before.  Many .cc files that include
http_response_info.h need to include those two headers.
It's a hassle.  This is a trade-off.

To show the benefit of this change, we should remove those
header includes from the .cc files that include
http_response_info.h.  At the very least, please
fix http_response_info.cc.  Here is the list for the net
module:

net/url_request/url_request_http_job.cc:#include "net/http/http_response_info.h"
net/url_request/view_cache_helper.cc:#include "net/http/http_response_info.h"
net/http/http_response_info.cc:#include "net/http/http_response_info.h"
net/http/http_transaction_unittest.cc:#include "net/http/http_response_info.h"
net/http/http_cache.cc:#include "net/http/http_response_info.h"
net/http/http_cache_unittest.cc:#include "net/http/http_response_info.h"
net/tools/dump_cache/cache_dumper.cc:#include "net/http/http_response_info.h"
net/tools/dump_cache/upgrade.cc:#include "net/http/http_response_info.h"

I do see some of them get by without including those
two headers (especially ssl_cert_request_info.h) though.

Expand Messages | Collapse Messages