Chromium Code Reviews

Issue 216019: Add a handful of startup tests that run with different types of install extensions. (Closed)

Created:
11 years, 3 months ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
Erik does not do reviews
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a handful of startup tests that run with different types of installed extensions. BUG=18445 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26600

Patch Set 1 #

Total comments: 4

Patch Set 2 : updated comment #

Patch Set 3 : fixed test data #

Unified diffs Side-by-side diffs Stats (+506 lines, -21 lines)
A chrome/test/data/extensions/profiles/content_scripts1/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json View 1 chunk +8 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/content_scripts1/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script.js View 1 chunk +4 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/content_scripts1/Default/Preferences View 1 chunk +36 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/content_scripts50/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json View 1 chunk +57 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/content_scripts50/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/script.js View 1 chunk +4 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/content_scripts50/Default/Preferences View 1 chunk +85 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/empty/Default/Preferences View 1 chunk +15 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/toolstrips1/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json View 1 chunk +8 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/toolstrips1/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html View 1 chunk +5 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/toolstrips1/Default/Preferences View 1 chunk +36 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/toolstrips50/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/manifest.json View 1 chunk +73 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/toolstrips50/Default/Extensions/behllobkkfkfnphdnhnkndlbkcpglgmj/1.0.0.0/toolstrip1.html View 1 chunk +5 lines, -0 lines 0 comments
A chrome/test/data/extensions/profiles/toolstrips50/Default/Preferences View 1 chunk +101 lines, -0 lines 0 comments
M chrome/test/startup/startup_test.cc View 4 chunks +69 lines, -21 lines 0 comments

Messages

Total messages: 4 (0 generated)
Matt Perry
11 years, 3 months ago (2009-09-18 00:10:14 UTC) #1
Erik does not do reviews
what was the .script.js.swp file? http://codereview.chromium.org/216019/diff/1/12 File chrome/test/data/extensions/profiles/toolstrips1/Default/Preferences (right): http://codereview.chromium.org/216019/diff/1/12#newcode17 Line 17: "name": "50 toolstrips", ...
11 years, 3 months ago (2009-09-18 00:27:23 UTC) #2
Matt Perry
Removed the .swp file - damn vim. http://codereview.chromium.org/216019/diff/1/12 File chrome/test/data/extensions/profiles/toolstrips1/Default/Preferences (right): http://codereview.chromium.org/216019/diff/1/12#newcode17 Line 17: "name": ...
11 years, 3 months ago (2009-09-18 00:51:20 UTC) #3
Erik does not do reviews
11 years, 3 months ago (2009-09-18 01:00:49 UTC) #4
LGTM

Powered by Google App Engine