Issue 216018: Fix a bug where we access a view after deletion....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216018: Fix a bug where we access a view after deletion.... (Closed)

Created:
11 years, 3 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a bug where we access a view after deletion. When the download shelf menu option 'Remove' is chosen, the view is removed and deleted (along with the object representing the download) so we must not access them after the removal. This CL NULLs the download pointer in the menu to prevent any futher access. BUG=20810 TEST=Remove an item from the download shelf and Chrome should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26536

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
M	chrome/browser/download/download_shelf.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/download/download_shelf.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/views/download_item_view.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages