Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 2158002: Merge 59950 - WebCore: Fix for <rdar://problem/8009118> Crash in WebCore::toA... (Closed)

Created:
10 years, 7 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 59950 - WebCore: Fix for <rdar://problem/8009118> Crash in WebCore::toAlphabetic() while running MangleMe and corresponding https://bugs.webkit.org/show_bug.cgi?id=39508 Reviewed by Darin Adler. The math was slightly off here, and we wound up trying to access an array at index 1 in some cases. We need to decrement numberShadow rather than subtracting one from the result of the modulo operation. * rendering/RenderListMarker.cpp: (WebCore::toAlphabeticOrNumeric): LayoutTests: Test for <rdar://problem/8009118> Crash in WebCore::toAlphabetic() while running MangleMe and corresponding https://bugs.webkit.org/show_bug.cgi?id=39508 Reviewed by Darin Adler. * fast/lists/alphaboundaryvalues.html: Added. * platform/mac/fast/lists/alphaboundaryvaluesexpected.checksum: Added. * platform/mac/fast/lists/alphaboundaryvaluesexpected.png: Added. * platform/mac/fast/lists/alphaboundaryvaluesexpected.txt: Added. TBR=bdakin@apple.com BUG=44955 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -2 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/lists/alpha-boundary-values.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac/fast/lists/alpha-boundary-values-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/platform/mac/fast/lists/alpha-boundary-values-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac/fast/lists/alpha-boundary-values-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +17 lines, -0 lines 0 comments Download
M WebCore/rendering/RenderListMarker.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 7 months ago (2010-05-24 23:25:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698