Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2155003: Merge 58829 - Reviewed by Adele Peterson.... (Closed)

Created:
10 years, 7 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 58829 - Reviewed by Adele Peterson. https://bugs.webkit.org/show_bug.cgi?id=26824 <rdar://problem/7018610> EventHandler can operate on a wrong frame if focus changes during keyboard event dispatch. EventHandler object is tied to a frame, so it's wrong for it to continue processing a keyboard event if focused frame changes between keydown and keypress. * manualtests/focuschangebetweenkeyevents.html: Added. * page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Bail out early if focused frame changes while dispatching keydown. Also made similar changes for Windows to maintain matching behavior, even though EventHandler was reentered anyway due to WM_KEYDOWN and WM_CHAR being separate events. BUG=15766 TBR=ap@apple.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -2 lines) Patch
M WebCore/ChangeLog View 1 chunk +18 lines, -0 lines 0 comments Download
A WebCore/manual-tests/focus-change-between-key-events.html View 1 chunk +24 lines, -0 lines 0 comments Download
M WebCore/page/EventHandler.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 7 months ago (2010-05-24 19:31:25 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698