Add developer tools message handling to renderer

DevToolsAgent provides IPC access to the inspected page from developer tools.

RenderView running developer tools front-end instantiates DevToolsClient that handles IPC communication with DevToolsAgent.

All messages are wrapped and routed through browser process.

darin: please look at changes related to messages handling in RenderView

jam: please review handling of forwarded messages in DevToolsClient and DevToolsAgent. 

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10459

[yurys, 2009-02-24 19:55:24]

Forwarded messages are wrapped only on the first hop(renderer->browser). 

RenderView delegates ToolsClient messages to ToolsClient if it exists.
ToolsClient handles messages in render thread.

ToolsAgent runs in IO thread(and so needs to be a MessageFilter) so that tools
messages can still be processed when v8 is stopped on breakpoint.

[jam, 2009-02-25 00:12:51]

http://codereview.chromium.org/21543/diff/3001/4011
File chrome/renderer/tools_agent.h (right):

http://codereview.chromium.org/21543/diff/3001/4011#newcode13
Line 13: #include "chrome/renderer/tools_messages.h"
this isn't needed (and if it was, we'd want to factor out structs from the
file).  the reason is that it slows compilation when header files include
*_messages.h".  tools is probably small now, but it's a pattern that we want to
avoid since it really slows down the build when someone includes
render_message.h from a header

http://codereview.chromium.org/21543/diff/3001/4012
File chrome/renderer/tools_client.h (right):

http://codereview.chromium.org/21543/diff/3001/4012#newcode12
Line 12: #include "chrome/renderer/tools_messages.h"
same here, take out this include

[Søren Thygesen Gjesse, 2009-02-25 08:20:54]

LGTM

http://codereview.chromium.org/21543/diff/3001/4009
File chrome/renderer/tools_agent.cc (right):

http://codereview.chromium.org/21543/diff/3001/4009#newcode54
Line 54: // It's possible that this will get cleared out from under us.
Comment indicate that something (view_?) could get cleared. Obsolete comment of
missing check?

http://codereview.chromium.org/21543/diff/3001/4011
File chrome/renderer/tools_agent.h (right):

http://codereview.chromium.org/21543/diff/3001/4011#newcode27
Line 27: // at least until OnFilterRemoved method is called.
OnFilterRemoved is not implemented in this class. Perhaps revise comment.

http://codereview.chromium.org/21543/diff/3001/4010
File chrome/renderer/tools_client.cc (right):

http://codereview.chromium.org/21543/diff/3001/4010#newcode33
Line 33: IPC_MESSAGE_HANDLER(ToolsClientMsg_DidDebugAttach, DidDebugAttach)
Did you leave out DebuggerOutput on purpose?

[yurys, 2009-02-25 15:18:53]

http://codereview.chromium.org/21543/diff/3001/4009
File chrome/renderer/tools_agent.cc (right):

http://codereview.chromium.org/21543/diff/3001/4009#newcode54
Line 54: // It's possible that this will get cleared out from under us.
On 2009/02/25 08:20:55, Søren Gjesse wrote:
> Comment indicate that something (view_?) could get cleared. Obsolete comment
of
> missing check?

Missing check. Fixed.

http://codereview.chromium.org/21543/diff/3001/4011
File chrome/renderer/tools_agent.h (right):

http://codereview.chromium.org/21543/diff/3001/4011#newcode13
Line 13: #include "chrome/renderer/tools_messages.h"
On 2009/02/25 00:12:51, John Abd-El-Malek wrote:
> this isn't needed (and if it was, we'd want to factor out structs from the
> file).  the reason is that it slows compilation when header files include
> *_messages.h".  tools is probably small now, but it's a pattern that we want
to
> avoid since it really slows down the build when someone includes
> render_message.h from a header

Done. We didn't need that #include here.

http://codereview.chromium.org/21543/diff/3001/4011#newcode27
Line 27: // at least until OnFilterRemoved method is called.
On 2009/02/25 08:20:55, Søren Gjesse wrote:
> OnFilterRemoved is not implemented in this class. Perhaps revise comment.
> 

Done.

http://codereview.chromium.org/21543/diff/3001/4010
File chrome/renderer/tools_client.cc (right):

http://codereview.chromium.org/21543/diff/3001/4010#newcode33
Line 33: IPC_MESSAGE_HANDLER(ToolsClientMsg_DidDebugAttach, DidDebugAttach)
On 2009/02/25 08:20:55, Søren Gjesse wrote:
> Did you leave out DebuggerOutput on purpose?
Yes, I'll add it later.

http://codereview.chromium.org/21543/diff/3001/4012
File chrome/renderer/tools_client.h (right):

http://codereview.chromium.org/21543/diff/3001/4012#newcode12
Line 12: #include "chrome/renderer/tools_messages.h"
On 2009/02/25 00:12:51, John Abd-El-Malek wrote:
> same here, take out this include

Done. I cleaned up #include list a bit.

[yurys, 2009-02-25 15:24:34]

Tools prefix changed to more specific DevTools

[yurys, 2009-02-26 10:44:42]

I removed code the part of change modifying code in Glue. As a result
DevToolsClient became almost empty. It is going to delegate message handling to
dev tools frontend implemented in Glue. We will check in this in a separate CL.

[Søren Thygesen Gjesse, 2009-02-26 11:16:32]

LGTM

http://codereview.chromium.org/21543/diff/4152/4158
File chrome/renderer/dev_tools_client.h (right):

http://codereview.chromium.org/21543/diff/4152/4158#newcode21
Line 21: // a code in glue
a code in glue -> code in glue

[yurys, 2009-02-26 11:17:50]

http://codereview.chromium.org/21543/diff/4152/4158
File chrome/renderer/dev_tools_client.h (right):

http://codereview.chromium.org/21543/diff/4152/4158#newcode21
Line 21: // a code in glue
On 2009/02/26 11:16:33, Søren Gjesse wrote:
> a code in glue -> code in glue

Done.