Issue 21512: Hook up the resize rect for Mac and enable its use in the renderer (mac-only)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21512: Hook up the resize rect for Mac and enable its use in the renderer (mac-only)... (Closed)

Created:
11 years, 10 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
MAD, TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Hook up the resize rect for Mac and enable its use in the renderer (mac-only). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10019

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 10 months ago

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -3 lines)
M	chrome/browser/browser_window_cocoa.mm	View	1 chunk	+9 lines, -3 lines	0 comments
M	chrome/browser/browser_window_controller.h	View	1 chunk	+5 lines, -0 lines	0 comments
M	chrome/browser/browser_window_controller.mm	View	1 chunk	+8 lines, -0 lines	0 comments
M	chrome/browser/cocoa/tab_contents_controller.h	View	1 chunk	+5 lines, -0 lines	0 comments
M	chrome/browser/cocoa/tab_contents_controller.mm	View	1 chunk	+22 lines, -0 lines	0 comments
M	chrome/browser/cocoa/tab_strip_controller.h	View	1 chunk	+5 lines, -0 lines	0 comments
M	chrome/browser/cocoa/tab_strip_controller.mm	View	1 chunk	+18 lines, -0 lines	0 comments
M	chrome/renderer/render_widget.cc	View	1 chunk	+5 lines, -0 lines	1 comment

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

TVL: review MAD: FYI on change to renderer specifically for Mac. I'll look into page-cycler ...

11 years, 10 months ago (2009-02-19 17:45:15 UTC) #1

MAD

11 years, 10 months ago (2009-02-19 18:55:12 UTC) #3

Small detail...

BYE
MAD

http://codereview.chromium.org/21512/diff/13/21
File chrome/renderer/render_widget.cc (right):

http://codereview.chromium.org/21512/diff/13/21#newcode706
Line 706: #if defined(OS_MACOSX)
Can you move the comment above within the elif?

Expand Messages | Collapse Messages