Reorder the color_utils functions in preparation for adding more:...

Reorder the color_utils functions in preparation for adding more:
* Put helper functions in a block at the top of the file (which we can then use an anonymous namespace around)
* Make main function order a little more consistent

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26827

[brettw, 2009-09-22 16:40:51]

LGTM

http://codereview.chromium.org/215049/diff/1/2
File app/gfx/color_utils.cc (right):

http://codereview.chromium.org/215049/diff/1/2#newcode28
Line 28: // http://en.wikipedia.org/wiki/SRGB_color_space#
I would have kept this link as-is, since now nobody can copy/paste it or click
it (in VS). There is an explicit exception in the style guide for longer URLs.

http://codereview.chromium.org/215049/diff/1/2#newcode152
Line 152: xyz->X =
Can you indent the wrapped lines 2 more spaces while you're here? I would have
probably wrapped this as:
xyz->X = 0.4124 * CIEConvertNonLinear(r) +
         0.3576 * CIEConvertNonLinear(g) +
         0.1805 * CIEConvertNonLinear(g);
but that's up to you.

[Peter Kasting, 2009-09-22 17:14:07]

On 2009/09/22 16:40:51, brettw wrote:
> http://codereview.chromium.org/215049/diff/1/2#newcode28
> Line 28: // http://en.wikipedia.org/wiki/SRGB_color_space#
> I would have kept this link as-is, since now nobody can copy/paste it or click
> it (in VS). There is an explicit exception in the style guide for longer URLs.

Oh, good to know.  I prefer it the unbroken way so I'm happy to change it back
:)

> http://codereview.chromium.org/215049/diff/1/2#newcode152
> Line 152: xyz->X =
> Can you indent the wrapped lines 2 more spaces while you're here? I would have
> probably wrapped this as:
> xyz->X = 0.4124 * CIEConvertNonLinear(r) +
>          0.3576 * CIEConvertNonLinear(g) +
>          0.1805 * CIEConvertNonLinear(g);
> but that's up to you.

You are anticipating my next CL which tried to clean up the functions more -- I
rewrapped in precisely this way there.  I'll go ahead and make this particular
change in this CL and commit.