Issue 215019: Dashboard UI changes....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215019: Dashboard UI changes.... (Closed)

Created:
11 years, 3 months ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Dashboard UI changes. 1. Allow hiding/showing of the legend. 2. Fix number of results input to actually work (i.e. invalidate old data). 3. Making clicking on test links put up a popup with the information for the test across all builders. 4. Fix blamelists to not have an off-by-one error in the previous revision. 5. Make maxResults work when viewing an individual test across all builders. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26572

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -77 lines)			Patch
	M	webkit/tools/layout_tests/flakiness_dashboard.html	View		19 chunks	+147 lines, -77 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

11 years, 3 months ago (2009-09-18 02:35:24 UTC) #2

LGTM

http://codereview.chromium.org/215019/diff/1/2
File webkit/tools/layout_tests/flakiness_dashboard.html (right):

http://codereview.chromium.org/215019/diff/1/2#newcode181
Line 181: #popup > * {
remove empty rule?

http://codereview.chromium.org/215019/diff/1/2#newcode1242
Line 1242: 'run that tst or all runs of the test passed.</b></div>';
s/tst/test/

Expand Messages | Collapse Messages