Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 21477: Remove code that adds "Url Protocol" key to registry entry... (Closed)

Created:
11 years, 10 months ago by Sverrir
Modified:
9 years, 7 months ago
Reviewers:
kuchhal, SkyLined
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove code that adds "Url Protocol" key to registry entry for ChromeHTML. This removes the feature where you can launch Chrome using chromehtml: links in e.g. IE. BUG=5825 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10357

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/installer/setup/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/shell_util.cc View 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sverrir
Remove the "URL Protocol" Value from registry. This is not required for file registration and ...
11 years, 10 months ago (2009-02-18 22:03:11 UTC) #1
kuchhal
I dont think we can remove URL Protocol key. See - http://src.chromium.org/viewvc/chrome?view=rev&revision=6376
11 years, 10 months ago (2009-02-18 22:28:22 UTC) #2
Sverrir
But they would not be looking under ChromeHTML but under http - right? We do ...
11 years, 10 months ago (2009-02-18 22:52:13 UTC) #3
SkyLined
This does not actually seem to remove the value: this removes the code that adds ...
11 years, 10 months ago (2009-02-25 20:42:28 UTC) #4
Sverrir
The RemoveUrlProtocol() is meant to remove the key - both for HKLM and HKCU.
11 years, 10 months ago (2009-02-25 21:51:00 UTC) #5
SkyLined
I see, I missed that earlier, sorry. What happens if the call fail, eg. when ...
11 years, 10 months ago (2009-02-26 09:07:43 UTC) #6
Sverrir
11 years, 9 months ago (2009-02-27 19:11:36 UTC) #7
I have another change pending that fixes that.  I was waiting for more feedback
on it but I guess its OK to check in as well.
See: http://codereview.chromium.org/20469/show

Powered by Google App Engine
This is Rietveld 408576698