Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 21475: Move units to new module printing. (Closed)

Created:
11 years, 10 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Move units to new module printing. Add printing_unittests on Windows too. Make test_shell and chrome_dll dependent on printing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10105

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -174 lines) Patch
M chrome/browser/browser.scons View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/browser.vcproj View 1 3 chunks +8 lines, -16 lines 0 comments Download
M chrome/browser/printing/print_settings.cc View 1 3 chunks +13 lines, -7 lines 1 comment Download
M chrome/browser/printing/printed_document.cc View 1 1 chunk +1 line, -1 line 1 comment Download
D chrome/browser/printing/units.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/printing/units.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/printing/units_unittest.cc View 1 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/chrome.sln View 7 chunks +36 lines, -0 lines 0 comments Download
M chrome/chrome.xcodeproj/project.pbxproj View 1 6 chunks +0 lines, -10 lines 0 comments Download
M chrome/chrome_kjs.sln View 6 chunks +40 lines, -0 lines 0 comments Download
M chrome/test/unit/unit_tests.scons View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/unit/unittests.vcproj View 1 1 chunk +0 lines, -4 lines 0 comments Download
A printing/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A printing/printing.vcproj View 1 chunk +147 lines, -0 lines 0 comments Download
A printing/printing.vsprops View 1 chunk +8 lines, -0 lines 0 comments Download
A printing/printing_unittests.vcproj View 1 chunk +165 lines, -0 lines 0 comments Download
A + printing/units.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + printing/units.cc View 2 chunks +1 line, -2 lines 0 comments Download
A + printing/units_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.sln View 4 chunks +12 lines, -0 lines 0 comments Download
M webkit/webkit_armu.sln View 4 chunks +12 lines, -0 lines 0 comments Download
M webkit/webkit_kjs.sln View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
I can't run this patch on the try server, hopefully it won't break anything. I ...
11 years, 10 months ago (2009-02-18 21:31:48 UTC) #1
M-A Ruel
I created a new module but only for windows for now.
11 years, 10 months ago (2009-02-20 17:17:02 UTC) #2
brettw
11 years, 10 months ago (2009-02-20 17:22:05 UTC) #3
LGTM

http://codereview.chromium.org/21475/diff/27/1027
File chrome/browser/printing/print_settings.cc (right):

http://codereview.chromium.org/21475/diff/27/1027#newcode9
Line 9: #include "printing/units.h"
Move down one.

http://codereview.chromium.org/21475/diff/27/1026
File chrome/browser/printing/printed_document.cc (right):

http://codereview.chromium.org/21475/diff/27/1026#newcode11
Line 11: #include "printing/units.h"
Move down so it's in order.

Powered by Google App Engine
This is Rietveld 408576698