Issue 21473: Now that we deal with string16s, provide some useful conversions for them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21473: Now that we deal with string16s, provide some useful conversions for them. (Closed)

Created:
11 years, 10 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Now that we deal with string16s, provide some useful conversions for them. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9970

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -8 lines)			Patch
	M	base/sys_string_conversions.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	base/sys_string_conversions_mac.mm	View	1	5 chunks	+19 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

11 years, 10 months ago (2009-02-18 21:17:48 UTC) #1

http://codereview.chromium.org/21473/diff/1/3
File base/sys_string_conversions_mac.mm (right):

http://codereview.chromium.org/21473/diff/1/3#newcode119
Line 119: #if defined(WCHAR_T_IS_UTF16)
If WCHAR_T_IS_UTF16 is ever defined, we'll probably get multiple definition
errors. Shall we just pull out that support? Do we really need to keep
pretending that perhaps someday we'll do short wchar_ts?

Expand Messages | Collapse Messages