src/x64/full-codegen-x64.cc - Issue 2144006: Cardmarking writebarrier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 2144006: Cardmarking writebarrier. (Closed)

Patch Set: change NewSpace and SemiSpace Contains to match HasHeapObjectTag Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index 81424f6611d8ae9402552b0e89fd29448a2d8efa..a0898976b02d7a0335180c5551feaea5062b401d 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -1010,7 +1010,6 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ push(rax); // Map.

__ push(rdx); // Enumeration cache.

__ movq(rax, FieldOperand(rdx, FixedArray::kLengthOffset));

- __ Integer32ToSmi(rax, rax);

__ push(rax); // Enumeration cache length (as smi).

__ Push(Smi::FromInt(0)); // Initial index.

__ jmp(&loop);

@@ -1020,7 +1019,6 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ Push(Smi::FromInt(0)); // Map (0) - force slow check.

__ push(rax);

__ movq(rax, FieldOperand(rax, FixedArray::kLengthOffset));

- __ Integer32ToSmi(rax, rax);

__ push(rax); // Fixed array length (as smi).

__ Push(Smi::FromInt(0)); // Initial index.