src/ia32/full-codegen-ia32.cc - Issue 2144006: Cardmarking writebarrier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 2144006: Cardmarking writebarrier. (Closed)

Patch Set: change NewSpace and SemiSpace Contains to match HasHeapObjectTag Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 368a8eeb0b56b1d42c4428cfa94d9d2f70272493..329f13d67b32e28f00894462812e4e0835025f47 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -1009,7 +1009,6 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ push(eax); // Map.

__ push(edx); // Enumeration cache.

__ mov(eax, FieldOperand(edx, FixedArray::kLengthOffset));

- __ SmiTag(eax);

__ push(eax); // Enumeration cache length (as smi).

__ push(Immediate(Smi::FromInt(0))); // Initial index.

__ jmp(&loop);

@@ -1019,7 +1018,6 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ push(Immediate(Smi::FromInt(0))); // Map (0) - force slow check.

__ push(eax);

__ mov(eax, FieldOperand(eax, FixedArray::kLengthOffset));

- __ SmiTag(eax);

__ push(eax); // Fixed array length (as smi).

__ push(Immediate(Smi::FromInt(0))); // Initial index.