Issue 21406: Changed all log messages to be handled through the LogMessageBuilder instead ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21406: Changed all log messages to be handled through the LogMessageBuilder instead ... (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Changed all log messages to be handled through the LogMessageBuilder instead of through fprintf directly to the log file. Added a flag for the runtime %Log call and fixed its arguments checking. Use of %Log is only for debugging. Committed: http://code.google.com/p/v8/source/detail?r=1290

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -109 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/log.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/log.cc	View	25 chunks	+158 lines, -105 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages