Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 214058: Create a separate function that returns the list of additional... (Closed)

Created:
11 years, 3 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
yaar
CC:
chromium-reviews_googlegroups.com, Mark Mentovai
Visibility:
Public.

Description

Create a separate function that returns the list of additional files to be included in the build (common.gypi and */supplement.gypi). BUG=none TEST=successful "gclient runhooks" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -20 lines) Patch
M build/gyp_chromium View 2 chunks +30 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sgk
Taking the build/common.gypi includes out of the .gyp files means the individual .gyp files are ...
11 years, 3 months ago (2009-09-22 22:09:57 UTC) #1
yaar
11 years, 3 months ago (2009-09-22 22:18:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698