Issue 214029: Adding focus to NaviteViewHost.

Issue 214029: Adding focus to NaviteViewHost. (Closed)

Created:
11 years, 3 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, pam+watch_chromium.org, Ben Goodger (Google), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Refactoring some of the NativeViewHost and NativeControl focus management so their consumers don't have to explicitly set the focused view. BUG=None TEST=Run all tests. Make sure focus is stored/restored properly in Chrome. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27113

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+268 lines, -121 lines)			Patch
M	base/win_util.cc	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.h	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view.h	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc	View	1 2 3 4 5 6 7	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_win.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_win.cc	View	1 2 3 4 5 6 7	2 chunks	+4 lines, -9 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	1 2 3 4 5 6 7	3 chunks	+5 lines, -11 lines	0 comments	Download
M	views/controls/native/native_view_host.h	View	1 2 3 4 5 6 7	3 chunks	+27 lines, -8 lines	0 comments	Download
M	views/controls/native/native_view_host.cc	View	1 2 3 4 5 6 7	6 chunks	+34 lines, -6 lines	0 comments	Download
M	views/controls/native/native_view_host_gtk.h	View	1 2 3 4 5 6 7	3 chunks	+3 lines, -5 lines	0 comments	Download
M	views/controls/native/native_view_host_gtk.cc	View	1 2 3 4 5 6 7	4 chunks	+7 lines, -20 lines	0 comments	Download
M	views/controls/native/native_view_host_win.h	View	1 2 3 4 5 6 7	3 chunks	+14 lines, -4 lines	0 comments	Download
M	views/controls/native/native_view_host_win.cc	View	1 2 3 4 5 6 7	4 chunks	+43 lines, -3 lines	0 comments	Download
M	views/controls/native/native_view_host_wrapper.h	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -3 lines	0 comments	Download
M	views/controls/native_control.cc	View	5 6 7	1 chunk	+0 lines, -2 lines	0 comments	Download
M	views/controls/native_control_gtk.h	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -4 lines	0 comments	Download
M	views/controls/native_control_gtk.cc	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -20 lines	0 comments	Download
M	views/controls/native_control_win.cc	View	1 2 3 4 5 6 7	4 chunks	+11 lines, -20 lines	0 comments	Download
M	views/focus/focus_manager_unittest.cc	View	1 2 3 4 5 6 7	3 chunks	+103 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages