Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: tests/gclient_test.py

Issue 214017: gclient_scm: add test to catch bug fixed by r208010 (Closed)
Patch Set: add bug explanation Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_test.py
diff --git a/tests/gclient_test.py b/tests/gclient_test.py
index 305736d536ac22792995f112eef5c5f802518da5..8d9295cd209313580cc63d7d760adce8c61bb13d 100644
--- a/tests/gclient_test.py
+++ b/tests/gclient_test.py
@@ -1117,6 +1117,8 @@ class SCMWrapperTestCase(GClientBaseTestCase):
relpath=self.relpath)
file_list = []
scm.revert(options, self.args, file_list)
+ self.assertEquals(sorted(file_list), sorted([os.path.join(base_path, 'a'),
+ os.path.join(base_path, 'b')]))
def testRevertUnversionedUnexpectedFile(self):
options = self.Options(verbose=True)
@@ -1137,6 +1139,8 @@ class SCMWrapperTestCase(GClientBaseTestCase):
relpath=self.relpath)
file_list = []
scm.revert(options, self.args, file_list)
+ # TODO(msb): fix bug (file_list contains dupes) and enable assertion
+ #self.assertEquals(file_list, [os.path.join(base_path, 'a')])
def testStatus(self):
options = self.Options(verbose=True)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698