Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: base/debug_util_posix.cc

Issue 214012: Explicitly compare to NULL when looking for weak_import symbols. (Closed)
Patch Set: rebase Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug_util_posix.cc
diff --git a/base/debug_util_posix.cc b/base/debug_util_posix.cc
index fe72c3c49c479c1cbc2deb2327ed3ea0e54f4f32..dc86c8c5720d4fb7b817b3d69ef422ca36618be4 100644
--- a/base/debug_util_posix.cc
+++ b/base/debug_util_posix.cc
@@ -121,7 +121,7 @@ void DebugUtil::BreakDebugger() {
StackTrace::StackTrace() {
#if defined(OS_MACOSX) && MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_5
- if (!backtrace) {
+ if (backtrace == NULL) {
count_ = 0;
return;
}
@@ -133,7 +133,7 @@ StackTrace::StackTrace() {
void StackTrace::PrintBacktrace() {
#if defined(OS_MACOSX) && MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_5
- if (!backtrace_symbols_fd)
+ if (backtrace_symbols_fd == NULL)
return;
#endif
fflush(stderr);
@@ -142,7 +142,7 @@ void StackTrace::PrintBacktrace() {
void StackTrace::OutputToStream(std::ostream* os) {
#if defined(OS_MACOSX) && MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_5
- if (!backtrace_symbols)
+ if (backtrace_symbols == NULL)
return;
#endif
scoped_ptr_malloc<char*> trace_symbols(backtrace_symbols(trace_, count_));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698