Issue 214011: Remove the theme popup menu and just have a reset button to match the other p...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 214011: Remove the theme popup menu and just have a reset button to match the other p... (Closed)

Created:
11 years, 3 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove the theme popup menu and just have a reset button to match the other platforms. This avoids us needed extra localization strings, and we'll look to pick up any new UI when it's done for all platforms. Remove the autoseparating_menu since it is no longer used. TEST=Prefs just has a reset button and no theme popup list. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26560

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -368 lines)			Patch
M	chrome/app/nibs/Preferences.xib	View	1	73 chunks	+127 lines, -249 lines	0 comments	Download
D	chrome/browser/cocoa/autoseparating_menu.h	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
D	chrome/browser/cocoa/autoseparating_menu.m	View	1	1 chunk	+0 lines, -26 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.h	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.mm	View	1	1 chunk	+3 lines, -74 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

11 years, 3 months ago (2009-09-17 16:45:35 UTC) #2

LGTM

http://codereview.chromium.org/214011/diff/1/5
File chrome/browser/cocoa/autoseparating_menu.h (left):

http://codereview.chromium.org/214011/diff/1/5#oldcode10
Line 10: @interface AutoseparatingMenu : NSMenu {
might we need this for anything else? move it to GTM perhaps?

Expand Messages | Collapse Messages