Issue 214010: More reliably find the .desktop file for the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 214010: More reliably find the .desktop file for the browser. (Closed)

Created:
11 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Mike Mammarella, tony

CC:
chromium-reviews_googlegroups.com, fta

Visibility:
Public.

Description

More reliably find the .desktop file for the browser. Also search in "applications" subdirectory of each of XDG_DATA_DIRS. TEST=See bug. BUG=21995 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26590

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	chrome/browser/shell_integration_linux.cc	View		1 chunk	+7 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Mammarella

11 years, 3 months ago (2009-09-17 17:23:53 UTC) #3

http://codereview.chromium.org/214010/diff/1/2
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/214010/diff/1/2#newcode93
Line 93: search_paths.push_back(data_dir.Append("applications"));
Technically the string constant should be wrapped in FILE_PATH_LITERAL, but this
file is only for Linux where that does nothing anyway.

Expand Messages | Collapse Messages