Chromium Code Reviews

Issue 214002: Resize the render widget host even if the widget is hidden. (Closed)

Created:
11 years, 3 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5), Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Size the render widget host view when the browser tries to set it to a particular size. BUG=21942 TEST=On Linux chrome, load a #anchor page in the background. After the page loads, view the tab. It should be scrolled to the right place.

Patch Set 1 #

Total comments: 1

Patch Set 2 : gtk plumbing #

Patch Set 3 : set size #

Unified diffs Side-by-side diffs Stats (+34 lines, -29 lines)
M chrome/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +4 lines, -0 lines 0 comments
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 3 chunks +17 lines, -15 lines 0 comments
M chrome/browser/tab_contents/tab_contents_view_gtk.h View 1 chunk +4 lines, -0 lines 0 comments
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 3 chunks +9 lines, -14 lines 0 comments

Messages

Total messages: 9 (0 generated)
tony
11 years, 3 months ago (2009-09-17 00:24:46 UTC) #1
Evan Stade
looks ok to me
11 years, 3 months ago (2009-09-17 02:35:34 UTC) #2
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/214002/diff/1/2 File chrome/browser/renderer_host/render_widget_host.cc (right): http://codereview.chromium.org/214002/diff/1/2#newcode645 Line 645: I am afraid of side effects, this will ...
11 years, 3 months ago (2009-09-17 18:46:43 UTC) #3
tony
Here's a better fix that just makes the GTK code more like the views code. ...
11 years, 3 months ago (2009-09-17 20:48:53 UTC) #4
tony
On 2009/09/17 20:48:53, tony wrote: > Here's a better fix that just makes the GTK ...
11 years, 3 months ago (2009-09-17 23:05:24 UTC) #5
Evan Stade
I am kind of confused how this interacts with 201130. RWHVGtk changes are the same, ...
11 years, 3 months ago (2009-09-17 23:28:37 UTC) #6
tony
On 2009/09/17 23:28:37, Evan Stade wrote: > I am kind of confused how this interacts ...
11 years, 3 months ago (2009-09-17 23:31:00 UTC) #7
cpu_(ooo_6.6-7.5)
I am not familiar with this but have my LG pending Stade's comments. On 2009/09/17 ...
11 years, 3 months ago (2009-09-18 17:26:26 UTC) #8
Evan Stade
11 years, 3 months ago (2009-09-18 18:13:47 UTC) #9
(lgtm if it wasn't clear)

Powered by Google App Engine