Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2137005:
Update breakpad to the latest revision. (Closed)
|
Created:
10 years, 7 months ago by hansl_g Modified:
9 years, 7 months ago Reviewers:
Sigurður Ásgeirsson CC:
chromium-reviews Base URL:
svn://chrome-svn/chrome/trunk/src/ Visibility:
Public. |
DescriptionUpdate breakpad to the latest revision (599).
BUG=None
TEST=None
Submitted as http://codereview.chromium.org/2096013/show,
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47670
Patch Set 1 #Messages
Total messages: 7 (0 generated)
Easy one. The 2 tests on windows aren't failing because of this change. Thanks.
BUG=None TEST=None On Tue, May 18, 2010 at 2:24 PM, <hansl@google.com> wrote: > Reviewers: Ruðrugis, > > Message: > Easy one. The 2 tests on windows aren't failing because of this change. > > Thanks. > > Description: > Update breakpad to the latest revision (599). > BUG=0 > TEST=0 > > > Please review this at http://codereview.chromium.org/2137005/show > > SVN Base: svn://chrome-svn/chrome/trunk/src/ > > Affected files: > M DEPS > > > Index: DEPS > =================================================================== > --- DEPS (revision 47510) > +++ DEPS (working copy) > @@ -11,7 +11,7 @@ > > deps = { > "src/breakpad/src": > - "http://google-breakpad.googlecode.com/svn/trunk/src@568", > + "http://google-breakpad.googlecode.com/svn/trunk/src@599", > > "src/build/util/support": > "/trunk/deps/support@20411", > > >
The issue doesn't show a link to the windows try server, what was the problem? On Tue, May 18, 2010 at 3:01 PM, Sigurður Ásgeirsson <siggi@chromium.org> wrote: > BUG=None > TEST=None > > On Tue, May 18, 2010 at 2:24 PM, <hansl@google.com> wrote: >> Reviewers: Ruðrugis, >> >> Message: >> Easy one. The 2 tests on windows aren't failing because of this change. >> >> Thanks. >> >> Description: >> Update breakpad to the latest revision (599). >> BUG=0 >> TEST=0 >> >> >> Please review this at http://codereview.chromium.org/2137005/show >> >> SVN Base: svn://chrome-svn/chrome/trunk/src/ >> >> Affected files: >> M DEPS >> >> >> Index: DEPS >> =================================================================== >> --- DEPS (revision 47510) >> +++ DEPS (working copy) >> @@ -11,7 +11,7 @@ >> >> deps = { >> "src/breakpad/src": >> - "http://google-breakpad.googlecode.com/svn/trunk/src@568", >> + "http://google-breakpad.googlecode.com/svn/trunk/src@599", >> >> "src/build/util/support": >> "/trunk/deps/support@20411", >> >> >> >
Done.
It looks like windows hasn't completed yet (I didn't receive a fail or success yet). From my tries yesterday there was 2 red tests (copied here). On ui_tests: > WorkerTest.FLAKY_WorkerHttpLayoutTests EarlyReturnTest.ToastCrasher and on interactive_ui_tests: > TabDraggingTest.FLAKY_Tab1Tab3Escape Both are not a result of this change. I notified maruel about it. I will come back to you when I receive news from the tryserver. hans On Tue, May 18, 2010 at 15:02, Sigurður Ásgeirsson <siggi@chromium.org>wrote: > The issue doesn't show a link to the windows try server, what was the > problem? > > On Tue, May 18, 2010 at 3:01 PM, Sigurður Ásgeirsson <siggi@chromium.org> > wrote: > > BUG=None > > TEST=None > > > > On Tue, May 18, 2010 at 2:24 PM, <hansl@google.com> wrote: > >> Reviewers: Ruðrugis, > >> > >> Message: > >> Easy one. The 2 tests on windows aren't failing because of this change. > >> > >> Thanks. > >> > >> Description: > >> Update breakpad to the latest revision (599). > >> BUG=0 > >> TEST=0 > >> > >> > >> Please review this at http://codereview.chromium.org/2137005/show > >> > >> SVN Base: svn://chrome-svn/chrome/trunk/src/ > >> > >> Affected files: > >> M DEPS > >> > >> > >> Index: DEPS > >> =================================================================== > >> --- DEPS (revision 47510) > >> +++ DEPS (working copy) > >> @@ -11,7 +11,7 @@ > >> > >> deps = { > >> "src/breakpad/src": > >> - "http://google-breakpad.googlecode.com/svn/trunk/src@568", > >> + "http://google-breakpad.googlecode.com/svn/trunk/src@599", > >> > >> "src/build/util/support": > >> "/trunk/deps/support@20411", > >> > >> > >> > > >
lgtm, do you need me to submit on your behalf? On Tue, May 18, 2010 at 3:07 PM, Hans Larsen <hansl@google.com> wrote: > It looks like windows hasn't completed yet (I didn't receive a fail or > success yet). From my tries yesterday there was 2 red tests (copied here). > On ui_tests: >> >> WorkerTest.FLAKY_WorkerHttpLayoutTests >> >> EarlyReturnTest.ToastCrasher > > and on interactive_ui_tests: >> >> TabDraggingTest.FLAKY_Tab1Tab3Escape > > Both are not a result of this change. I notified maruel about it. > I will come back to you when I receive news from the tryserver. > hans > On Tue, May 18, 2010 at 15:02, Sigurður Ásgeirsson <siggi@chromium.org> > wrote: >> >> The issue doesn't show a link to the windows try server, what was the >> problem? >> >> On Tue, May 18, 2010 at 3:01 PM, Sigurður Ásgeirsson <siggi@chromium.org> >> wrote: >> > BUG=None >> > TEST=None >> > >> > On Tue, May 18, 2010 at 2:24 PM, <hansl@google.com> wrote: >> >> Reviewers: Ruðrugis, >> >> >> >> Message: >> >> Easy one. The 2 tests on windows aren't failing because of this change. >> >> >> >> Thanks. >> >> >> >> Description: >> >> Update breakpad to the latest revision (599). >> >> BUG=0 >> >> TEST=0 >> >> >> >> >> >> Please review this at http://codereview.chromium.org/2137005/show >> >> >> >> SVN Base: svn://chrome-svn/chrome/trunk/src/ >> >> >> >> Affected files: >> >> M DEPS >> >> >> >> >> >> Index: DEPS >> >> =================================================================== >> >> --- DEPS (revision 47510) >> >> +++ DEPS (working copy) >> >> @@ -11,7 +11,7 @@ >> >> >> >> deps = { >> >> "src/breakpad/src": >> >> - "http://google-breakpad.googlecode.com/svn/trunk/src@568", >> >> + "http://google-breakpad.googlecode.com/svn/trunk/src@599", >> >> >> >> "src/build/util/support": >> >> "/trunk/deps/support@20411", >> >> >> >> >> >> >> > > >
Yes, please do. The win trybot came back just a minute ago, and none of the reported problems are related to this change. On Tue, May 18, 2010 at 15:09, Sigurður Ásgeirsson <siggi@chromium.org>wrote: > lgtm, do you need me to submit on your behalf? > > On Tue, May 18, 2010 at 3:07 PM, Hans Larsen <hansl@google.com> wrote: > > It looks like windows hasn't completed yet (I didn't receive a fail or > > success yet). From my tries yesterday there was 2 red tests (copied > here). > > On ui_tests: > >> > >> WorkerTest.FLAKY_WorkerHttpLayoutTests > >> > >> EarlyReturnTest.ToastCrasher > > > > and on interactive_ui_tests: > >> > >> TabDraggingTest.FLAKY_Tab1Tab3Escape > > > > Both are not a result of this change. I notified maruel about it. > > I will come back to you when I receive news from the tryserver. > > hans > > On Tue, May 18, 2010 at 15:02, Sigurður Ásgeirsson <siggi@chromium.org> > > wrote: > >> > >> The issue doesn't show a link to the windows try server, what was the > >> problem? > >> > >> On Tue, May 18, 2010 at 3:01 PM, Sigurður Ásgeirsson < > siggi@chromium.org> > >> wrote: > >> > BUG=None > >> > TEST=None > >> > > >> > On Tue, May 18, 2010 at 2:24 PM, <hansl@google.com> wrote: > >> >> Reviewers: Ruðrugis, > >> >> > >> >> Message: > >> >> Easy one. The 2 tests on windows aren't failing because of this > change. > >> >> > >> >> Thanks. > >> >> > >> >> Description: > >> >> Update breakpad to the latest revision (599). > >> >> BUG=0 > >> >> TEST=0 > >> >> > >> >> > >> >> Please review this at http://codereview.chromium.org/2137005/show > >> >> > >> >> SVN Base: svn://chrome-svn/chrome/trunk/src/ > >> >> > >> >> Affected files: > >> >> M DEPS > >> >> > >> >> > >> >> Index: DEPS > >> >> =================================================================== > >> >> --- DEPS (revision 47510) > >> >> +++ DEPS (working copy) > >> >> @@ -11,7 +11,7 @@ > >> >> > >> >> deps = { > >> >> "src/breakpad/src": > >> >> - "http://google-breakpad.googlecode.com/svn/trunk/src@568", > >> >> + "http://google-breakpad.googlecode.com/svn/trunk/src@599", > >> >> > >> >> "src/build/util/support": > >> >> "/trunk/deps/support@20411", > >> >> > >> >> > >> >> > >> > > > > > > |
