Issue 21370: Implement deferToInterceptor function to help with readability of the binding...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21370: Implement deferToInterceptor function to help with readability of the binding... (Closed)

Created:
11 years, 10 months ago by dglazkov

Modified:
7 years, 5 months ago

Reviewers:
macdome, Mads Ager (chromium), eseidel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implement deferToInterceptor function to help with readability of the bindings code. R=eseidel

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	third_party/WebKit/WebCore/bindings/v8/V8Proxy.h	View		1 chunk	+7 lines, -0 lines	1 comment	Download
	M	third_party/WebKit/WebCore/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 10 months ago (2009-02-16 06:46:10 UTC) #3

LGTM, good idea to make the intention clear here.

http://codereview.chromium.org/21370/diff/1/2
File third_party/WebKit/WebCore/bindings/v8/V8Proxy.h (right):

http://codereview.chromium.org/21370/diff/1/2#newcode42
Line 42: inline static v8::Local<v8::Object> deferToInterceptor()
We should name this differently.  The NamedPropertyGetter/Setter and
IndexedPropertyGetter/Setter *are* the interceptors.  Returning an empty handle
from an interceptor signal to V8 that it should continue normal JavaScript
lookup on the actual JavaScript wrapper objects.  Call it something like
continueLookup?

Expand Messages | Collapse Messages