Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 21367: Add additional library dependencies for the shared linking of ipc_tests. (Closed)

Created:
11 years, 10 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add additional library dependencies for the shared linking of ipc_tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9815

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/common/ipc_tests.scons View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Not sure if this is the best way to do it. Suggestions welcome.
11 years, 10 months ago (2009-02-13 22:50:53 UTC) #1
tony
http://codereview.chromium.org/21367/diff/1/2 File chrome/common/ipc_tests.scons (right): http://codereview.chromium.org/21367/diff/1/2#newcode46 Line 46: 'sqlite', Can we just add these deps above? ...
11 years, 10 months ago (2009-02-13 23:37:22 UTC) #2
Lei Zhang
On 2009/02/13 23:37:22, tony wrote: > http://codereview.chromium.org/21367/diff/1/2 > File chrome/common/ipc_tests.scons (right): > > http://codereview.chromium.org/21367/diff/1/2#newcode46 > ...
11 years, 10 months ago (2009-02-13 23:46:26 UTC) #3
tony
11 years, 10 months ago (2009-02-13 23:53:12 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698