Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2136018: Fix for flickering of images on login screen.... (Closed)

Created:
10 years, 7 months ago by whywhat
Modified:
9 years, 7 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fix for flickering of images on login screen. Changed image resizing logic to show full size ghost and question mark images. BUG=chromiumos:2856 TEST=Login and logout. Check that user images are not shown partially for short period of time before drawn correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M chrome/browser/chromeos/login/user_controller.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_controller.cc View 4 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
whywhat
Please, take a look.
10 years, 7 months ago (2010-05-19 18:03:57 UTC) #1
Daniel Erat
10 years, 7 months ago (2010-05-19 18:07:36 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698