Issue 2135005: Integrated new bug icon in status bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2135005: Integrated new bug icon in status bar (Closed)

Created:
10 years, 7 months ago by zel

Modified:
10 years, 7 months ago

Reviewers:
rkc1, DaveMoore

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Integrated new bug icon in status bar. It opens bug reporting dialog. BUG=chromium-os:3348 TEST=click on the new bug icon in the status bar, it should open bug reporting dialog Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47749

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+270 lines, -0 lines)			Patch
A	chrome/app/theme/statusbar_feedback.png	View	1 2	Binary file		0 comments	Download
A	chrome/app/theme/statusbar_feedback_pressed.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/frame/browser_view.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/frame/browser_view.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/background_view.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/background_view.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/status/feedback_menu_button.h	View	1 2	1 chunk	+132 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/status/feedback_menu_button.cc	View	1 2	1 chunk	+113 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/status_area_host.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/status_area_view.h	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/status_area_view.cc	View	1 2	3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

10 years, 7 months ago (2010-05-19 02:33:58 UTC) #2

LGTM modulo nit.

Could you add a TODO / bug to me about sharing more code amongst all the
menu_buttons? It looks like they all implement the same interfaces, with empty
implementations (MenuModel, ViewMenuDelegate)

http://codereview.chromium.org/2135005/diff/13001/14008
File chrome/browser/chromeos/status/feedback_menu_button.cc (right):

http://codereview.chromium.org/2135005/diff/13001/14008#newcode44
chrome/browser/chromeos/status/feedback_menu_button.cc:44: // Draw the battery
icon 5 pixels down to center it.
Nit: Bad comment

Expand Messages | Collapse Messages