Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 21350: Better handling debug evaluation when there is no JavaScript stack (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Added check for existing frames to the evaluate debugger request. Fixed output of evaluated expressions from the debugger in the developer shell. Use global evaluate request from developer shell if there is no JavaScript stack. Remove use of JS2C macros in developer shell JavaScript code. Committed: http://code.google.com/p/v8/source/detail?r=1273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M src/d8.js View 3 chunks +8 lines, -4 lines 0 comments Download
M src/debug-delay.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-13 14:13:49 UTC) #1
Mads Ager (chromium)
11 years, 10 months ago (2009-02-13 14:17:42 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698