Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Side by Side Diff: src/debug-ia32.cc

Issue 21347: Make the debugger completely unload when the debug event listener is unregist... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/debug-arm.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 19 matching lines...) Expand all
30 #include "codegen-inl.h" 30 #include "codegen-inl.h"
31 #include "debug.h" 31 #include "debug.h"
32 32
33 33
34 namespace v8 { namespace internal { 34 namespace v8 { namespace internal {
35 35
36 36
37 // A debug break in the frame exit code is identified by a call instruction. 37 // A debug break in the frame exit code is identified by a call instruction.
38 bool BreakLocationIterator::IsDebugBreakAtReturn() { 38 bool BreakLocationIterator::IsDebugBreakAtReturn() {
39 // Opcode E8 is call. 39 // Opcode E8 is call.
40 return (*(rinfo()->pc()) == 0xE8); 40 return Debug::IsDebugBreakAtReturn(rinfo());
41 } 41 }
42 42
43 43
44 // Patch the JS frame exit code with a debug break call. See 44 // Patch the JS frame exit code with a debug break call. See
45 // CodeGenerator::VisitReturnStatement and VirtualFrame::Exit in codegen-ia32.cc 45 // CodeGenerator::VisitReturnStatement and VirtualFrame::Exit in codegen-ia32.cc
46 // for the precise return instructions sequence. 46 // for the precise return instructions sequence.
47 void BreakLocationIterator::SetDebugBreakAtReturn() { 47 void BreakLocationIterator::SetDebugBreakAtReturn() {
48 ASSERT(Debug::kIa32JSReturnSequenceLength >= 48 ASSERT(Debug::kIa32JSReturnSequenceLength >=
49 Debug::kIa32CallInstructionLength); 49 Debug::kIa32CallInstructionLength);
50 rinfo()->PatchCodeWithCall(Debug::debug_break_return_entry()->entry(), 50 rinfo()->PatchCodeWithCall(Debug::debug_break_return_entry()->entry(),
51 Debug::kIa32JSReturnSequenceLength - Debug::kIa32CallInstructionLength); 51 Debug::kIa32JSReturnSequenceLength - Debug::kIa32CallInstructionLength);
52 } 52 }
53 53
54 54
55 // Restore the JS frame exit code. 55 // Restore the JS frame exit code.
56 void BreakLocationIterator::ClearDebugBreakAtReturn() { 56 void BreakLocationIterator::ClearDebugBreakAtReturn() {
57 rinfo()->PatchCode(original_rinfo()->pc(), 57 rinfo()->PatchCode(original_rinfo()->pc(),
58 Debug::kIa32JSReturnSequenceLength); 58 Debug::kIa32JSReturnSequenceLength);
59 } 59 }
60 60
61 61
62 // Check whether the JS frame exit code has been patched with a debug break.
63 bool Debug::IsDebugBreakAtReturn(RelocInfo* rinfo) {
64 ASSERT(RelocInfo::IsJSReturn(rinfo->rmode()));
65 // Opcode E8 is call.
66 return (*(rinfo->pc()) == 0xE8);
67 }
68
69
62 #define __ masm-> 70 #define __ masm->
63 71
64 72
65 static void Generate_DebugBreakCallHelper(MacroAssembler* masm, 73 static void Generate_DebugBreakCallHelper(MacroAssembler* masm,
66 RegList pointer_regs, 74 RegList pointer_regs,
67 bool convert_call_to_jmp) { 75 bool convert_call_to_jmp) {
68 // Save the content of all general purpose registers in memory. This copy in 76 // Save the content of all general purpose registers in memory. This copy in
69 // memory is later pushed onto the JS expression stack for the fake JS frame 77 // memory is later pushed onto the JS expression stack for the fake JS frame
70 // generated and also to the C frame generated on top of that. In the JS 78 // generated and also to the C frame generated on top of that. In the JS
71 // frame ONLY the registers containing pointers will be pushed on the 79 // frame ONLY the registers containing pointers will be pushed on the
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 // No registers used on entry. 209 // No registers used on entry.
202 // ----------------------------------- 210 // -----------------------------------
203 Generate_DebugBreakCallHelper(masm, 0, false); 211 Generate_DebugBreakCallHelper(masm, 0, false);
204 } 212 }
205 213
206 214
207 #undef __ 215 #undef __
208 216
209 217
210 } } // namespace v8::internal 218 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/debug-arm.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698