Issue 21343: Make it possible to initialize KURLGoogle from a CString. This is so that I...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21343: Make it possible to initialize KURLGoogle from a CString. This is so that I... (Closed)

Created:
11 years, 10 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make it possible to initialize KURLGoogle from a CString. This is so that I can leverage the fact that CString has a CStringBuffer, which is reference counted. I want to be able to efficiently initialize a KURL from a CString that I already have. (If you are OK with this change, then I'll send it upstream.) R=brettw

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -22 lines)			Patch
M	third_party/WebKit/WebCore/platform/KURL.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/WebCore/platform/KURLGoogle.cpp	View	6 chunks	+20 lines, -17 lines	0 comments	Download
M	third_party/WebKit/WebCore/platform/KURLGooglePrivate.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/glue_util.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages