fix for issue 2610

fix for issue 2610
  - add back in RECOVERY variable since we can't specify value "0" in place
    of boolean flag "--recovery"
  - for recovery image, make ROOT-B 1GB, KERN-B 16MB and stateful partition 1GB

[adlr, 2010-05-18 21:56:22]

LGTM w/ one nit

http://codereview.chromium.org/2133006/diff/1/2
File src/platform/installer/chromeos-common.sh (right):

http://codereview.chromium.org/2133006/diff/1/2#newcode233
src/platform/installer/chromeos-common.sh:233: total_sectors=6561728
i'd just bump it to 3.9 MB (some "4MB" cards are actually less!). so sectors
would be 3900000 / 512

[Tan Gao, 2010-05-18 22:24:40]

http://codereview.chromium.org/2133006/diff/1/2
File src/platform/installer/chromeos-common.sh (right):

http://codereview.chromium.org/2133006/diff/1/2#newcode233
src/platform/installer/chromeos-common.sh:233: total_sectors=6561728
changed to 7617187 sectors (3,900,000,000 bytes / 512) and updated comment with
a TODO

[adlr, 2010-05-19 14:41:33]

http://codereview.chromium.org/2133006/diff/10001/11001
File src/platform/installer/chromeos-common.sh (right):

http://codereview.chromium.org/2133006/diff/10001/11001#newcode233
src/platform/installer/chromeos-common.sh:233: # TODO(tgao): do not hard code.
Use relative offset with a reasonable
can you just make this change now? it doesn't seem very big and it keeps a magic
number out of the codebase, which is nice.

[Tan Gao, 2010-05-19 14:45:21]

Sure, do we have a preference for the desired size of the stateful
partition? Once we decide on that, I can follow the relative offset logic to
compute the boundaries for all other partitions

Tan

On Wed, May 19, 2010 at 7:41 AM, <adlr@chromium.org> wrote:

>
> http://codereview.chromium.org/2133006/diff/10001/11001
>
> File src/platform/installer/chromeos-common.sh (right):
>
> http://codereview.chromium.org/2133006/diff/10001/11001#newcode233
> src/platform/installer/chromeos-common.sh:233: # TODO(tgao): do not hard
> code. Use relative offset with a reasonable
> can you just make this change now? it doesn't seem very big and it keeps
> a magic number out of the codebase, which is nice.
>
>
> http://codereview.chromium.org/2133006/show
>

[adlr, 2010-05-19 14:48:05]

You can use the value below, NUM_STATEFUL_SECTORS=$(roundup $(numsectors
$stateful_img))

On Wed, May 19, 2010 at 9:44 AM, Tan Gao <tgao@chromium.org> wrote:

> Sure, do we have a preference for the desired size of the stateful
> partition? Once we decide on that, I can follow the relative offset logic to
> compute the boundaries for all other partitions
>
> Tan
>
>
> On Wed, May 19, 2010 at 7:41 AM, <adlr@chromium.org> wrote:
>
>>
>> http://codereview.chromium.org/2133006/diff/10001/11001
>>
>> File src/platform/installer/chromeos-common.sh (right):
>>
>> http://codereview.chromium.org/2133006/diff/10001/11001#newcode233
>> src/platform/installer/chromeos-common.sh:233: # TODO(tgao): do not hard
>> code. Use relative offset with a reasonable
>> can you just make this change now? it doesn't seem very big and it keeps
>> a magic number out of the codebase, which is nice.
>>
>>
>> http://codereview.chromium.org/2133006/show
>>
>
>

[adlr, 2010-05-19 21:08:26]

LGTM