Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2133003: Allow build-time selection between ia32 and x86_64 in the GYP/Xcode Mac Chromium build (Closed)

Created:
10 years, 7 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allow build-time selection between ia32 and x86_64 in the GYP/Xcode Mac Chromium build. v8.gyp no longer sets any V8_TARGET_ARCH_* macro on the Mac. Instead, the proper V8_TARGET_ARCH_* macro will be set by src/globals.h in the same way as the V8_HOST_ARCH_* macro when it detects that no target macro is currently defined. The Mac build will attempt to compile all ia32 and x86_64 .cc files. #ifdef guards in each of these target-specific source files prevent their compilation when the associated target is not selected. For completeness, these #ifdef guards are also provided for the arm and mips .cc files. BUG=706 TEST=x86_64 Mac GYP/Xcode-based Chromium build (still depends on other changes) Committed: http://code.google.com/p/v8/source/detail?r=4666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -15 lines) Patch
M src/arm/assembler-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/assembler-thumb2.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/builtins-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/constants-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/cpu-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/debug-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/disasm-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/fast-codegen-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/frames-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/ic-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/jump-target-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/arm/register-allocator-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/arm/virtual-frame-arm.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/cpu-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/debug-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/frames-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/jump-target-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/ia32/register-allocator-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ia32/virtual-frame-ia32.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/codegen-mips.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/mips/constants-mips.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/mips/cpu-mips.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/mips/debug-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/disasm-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/fast-codegen-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/frames-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/mips/ic-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/jump-target-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/register-allocator-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/simulator-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/mips/virtual-frame-mips.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/cpu-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/debug-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/disasm-x64.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/frames-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/ic-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/jump-target-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/x64/register-allocator-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/x64/virtual-frame-x64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +24 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
Most of this, except for the very last file, is mechanical. The #ifdef guards all ...
10 years, 7 months ago (2010-05-14 20:04:01 UTC) #1
Mads Ager (chromium)
Mark, I might be missing something here, but selecting the right files to compile seems ...
10 years, 7 months ago (2010-05-17 09:43:13 UTC) #2
Mads Ager (chromium)
10 years, 7 months ago (2010-05-17 13:56:07 UTC) #3
LGTM in that case. Thanks for the explanations Mark. I really would prefer not
to have to do this to support XCode. Let me know if you find a way to get rid of
this again. :)

Powered by Google App Engine
This is Rietveld 408576698