Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2132018: Revert 47726 (turned nacl_ui_tests red) - Mac: First steps for default plugin... (Closed)

Created:
10 years, 7 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, jam+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 47726 (turned nacl_ui_tests red) - Mac: First steps for default plugin BUG=17392 TEST=Go to http://www.adobe.com/shockwave/welcome/. The task manager should show that the default plugin is running, and the "Missing Plugin" text should look slightly different than it did before. (this test depends on a small webkit patch) Requires commenting out if (objectContentType(url, mimeType) != ObjectContentNetscapePlugin) return 0; in WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp's createPlugin() as well, else the default plugin won't load. Review URL: http://codereview.chromium.org/2075006 TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -292 lines) Patch
M chrome/plugin/plugin_thread.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/default_plugin/default_plugin.gyp View 3 chunks +15 lines, -30 lines 0 comments Download
M webkit/default_plugin/plugin_impl_mac.h View 5 chunks +54 lines, -14 lines 0 comments Download
D webkit/default_plugin/plugin_impl_mac.mm View 1 chunk +0 lines, -179 lines 0 comments Download
M webkit/default_plugin/plugin_impl_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/default_plugin/plugin_impl_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webkit/default_plugin/plugin_main.cc View 5 chunks +6 lines, -57 lines 0 comments Download
M webkit/glue/plugins/plugin_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
10 years, 7 months ago (2010-05-19 21:55:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698