Update factory installer, factory test

Update factory installer, factory test
* Fix build breaks
* Update to work with EFI bios

[Nick Sanders, 2010-05-17 23:16:03]

Sorry for the large CL, but a lot of stopped working last week, and pretty much
all of this is necessary to generate any working factory_install. 

adlr: does the memento and devserver changes look OK?
wfrichar: postinst stuff look OK?
sosa: image_to_usb, mod_image_for_test stuff look OK?

Thanks,
  -Nick

http://codereview.chromium.org/2132008/diff/1/2
File src/platform/dev/autoupdate.py (right):

http://codereview.chromium.org/2132008/diff/1/2#newcode196
src/platform/dev/autoupdate.py:196: 'efipartitionimg_image': 'generic-efi.gz',
Need to install EFI partition at initial imaging.

http://codereview.chromium.org/2132008/diff/1/4
File src/platform/init/chromeos_startup (right):

http://codereview.chromium.org/2132008/diff/1/4#newcode28
src/platform/init/chromeos_startup:28: if [ ! -f /root/.factory_test ] && [ ! -f
/root/.factory_installer ]; then
Make splash screen dependent on tagging rather than emerge file munging.

http://codereview.chromium.org/2132008/diff/1/4#newcode47
src/platform/init/chromeos_startup:47: mount -n -t tmpfs tmp
/mnt/stateful_partition
make physical factory install shim SDCard completely read only.

http://codereview.chromium.org/2132008/diff/1/5
File src/platform/installer/chromeos-postinst (right):

http://codereview.chromium.org/2132008/diff/1/5#newcode50
src/platform/installer/chromeos-postinst:50:
${INSTALL_ROOT}/usr/sbin/chromos-setimage ${BOOT_SLOT} --dst=${ROOT_DEV}
Call EFI/grub updater at install or autoupdate time.

http://codereview.chromium.org/2132008/diff/1/5#newcode60
src/platform/installer/chromeos-postinst:60: dd if=${ROOT_DEV} bs=512 count=1
of=/tmp/oldpmbr.bin
Also maintain MBR setting for chromuimos or dogfood.

http://codereview.chromium.org/2132008/diff/1/6
File src/platform/memento_softwareupdate/memento_updater.sh (left):

http://codereview.chromium.org/2132008/diff/1/6#oldcode328
src/platform/memento_softwareupdate/memento_updater.sh:328: # partition
attributes bits to mark the new image as bootable.
moved to postinst.

http://codereview.chromium.org/2132008/diff/1/6
File src/platform/memento_softwareupdate/memento_updater.sh (right):

http://codereview.chromium.org/2132008/diff/1/6#newcode173
src/platform/memento_softwareupdate/memento_updater.sh:173: if [ ! -b
"$LOCAL_DEV" ]
regex is too complex, but not specific enough. Lets just make sure it's a real
device.

http://codereview.chromium.org/2132008/diff/1/7
File src/scripts/image_to_usb.sh (left):

http://codereview.chromium.org/2132008/diff/1/7#oldcode29
src/scripts/image_to_usb.sh:29: DEFINE_boolean install_autotest ${FLAGS_FALSE} \
install autotest is broken, permanently. Autotest is now officially way larger
than the stateful partition.

http://codereview.chromium.org/2132008/diff/1/8
File src/scripts/make_factory_package.sh (right):

http://codereview.chromium.org/2132008/diff/1/8#newcode2
src/scripts/make_factory_package.sh:2: 
handy omaha server generator.

http://codereview.chromium.org/2132008/diff/1/9
File src/scripts/mod_for_factory_scripts/200patchInitScript (left):

http://codereview.chromium.org/2132008/diff/1/9#oldcode85
src/scripts/mod_for_factory_scripts/200patchInitScript:85: -echo 0 >
/sys/devices/virtual/graphics/fbcon/cursor_blink
replaced with cleaner tagging method. Don't munge chromeos_startup anymore.

http://codereview.chromium.org/2132008/diff/1/9
File src/scripts/mod_for_factory_scripts/200patchInitScript (right):

http://codereview.chromium.org/2132008/diff/1/9#newcode9
src/scripts/mod_for_factory_scripts/200patchInitScript:9: 
tag to avoid splash screen.

http://codereview.chromium.org/2132008/diff/1/10
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/2132008/diff/1/10#newcode116
src/scripts/mod_image_for_test.sh:116: sudo rm -rf
/tmp/autotest/deps/realtimecomm_playground
Strip autotest of the largest, least useful for mfg stuff.

Note: we need a better way to do this long term.

http://codereview.chromium.org/2132008/diff/1/10#newcode188
src/scripts/mod_image_for_test.sh:188: if [ "${VERIFY}" = "true" ]; then
Have a look in the image. 
Any preference to leave this in for debugging, or delete it?

[sosa, 2010-05-17 23:26:32]

http://codereview.chromium.org/2132008/diff/1/7
File src/scripts/image_to_usb.sh (left):

http://codereview.chromium.org/2132008/diff/1/7#oldcode29
src/scripts/image_to_usb.sh:29: DEFINE_boolean install_autotest ${FLAGS_FALSE} \
Way larger than the stateful partition on a usb key*

On 2010/05/17 23:16:04, Nick Sanders wrote:
> install autotest is broken, permanently. Autotest is now officially way larger
> than the stateful partition.

http://codereview.chromium.org/2132008/diff/1/10
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/2132008/diff/1/10#newcode37
src/scripts/mod_image_for_test.sh:37: 
Remove extra line

http://codereview.chromium.org/2132008/diff/1/10#newcode42
src/scripts/mod_image_for_test.sh:42: 
Remove extra lines

http://codereview.chromium.org/2132008/diff/1/10#newcode104
src/scripts/mod_image_for_test.sh:104: autotest_client="/autotest"
Can you file an issue to portage-ize this?  Theoretically we should just emerge
chromeos-test with FEATURES=autotest but I'll have to dbl-check to make this
works as intended.

http://codereview.chromium.org/2132008/diff/1/10#newcode176
src/scripts/mod_image_for_test.sh:176: --root-deps=rdeps --nodeps
chromeos-factoryinstall
extra hanging space at end

[Nick Sanders, 2010-05-18 04:01:53]

http://codereview.chromium.org/2132008/diff/1/7
File src/scripts/image_to_usb.sh (left):

http://codereview.chromium.org/2132008/diff/1/7#oldcode29
src/scripts/image_to_usb.sh:29: DEFINE_boolean install_autotest ${FLAGS_FALSE} \
On 2010/05/17 23:26:32, sosa wrote:
> Way larger than the stateful partition on a usb key*

Ah, good point, it should still fit on the SSD stateful partition,  but it
doesn't fit on the USB key partition were installing on here..

http://codereview.chromium.org/2132008/diff/1/10
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/2132008/diff/1/10#newcode104
src/scripts/mod_image_for_test.sh:104: autotest_client="/autotest"
On 2010/05/17 23:26:32, sosa wrote:
> Can you file an issue to portage-ize this?  Theoretically we should just
emerge
> chromeos-test with FEATURES=autotest but I'll have to dbl-check to make this
> works as intended.

Good idea, filed: 
http://code.google.com/p/chromium-os/issues/detail?id=3335

http://codereview.chromium.org/2132008/diff/1/10#newcode176
src/scripts/mod_image_for_test.sh:176: --root-deps=rdeps --nodeps
chromeos-factoryinstall
On 2010/05/17 23:26:32, sosa wrote:
> extra hanging space at end

Done.

[adlr, 2010-05-18 17:27:04]

http://codereview.chromium.org/2132008/diff/14001/15004
File src/platform/installer/chromeos-postinst (right):

http://codereview.chromium.org/2132008/diff/14001/15004#newcode59
src/platform/installer/chromeos-postinst:59: # We'll fix this RSN.
you might want to add a note reminding people that code in here must work on all
versions of chromium os that we'll ship this update to, since it's using the
version of gpt that shipped down w/ that image (or, in the case of factory
install, the version on the shim).

http://codereview.chromium.org/2132008/diff/14001/15005
File src/platform/memento_softwareupdate/memento_updater.sh (left):

http://codereview.chromium.org/2132008/diff/14001/15005#oldcode325
src/platform/memento_softwareupdate/memento_updater.sh:325: echo 3 >
/proc/sys/vm/drop_caches
we should probably keep this here, b/c it won't cause much performace drop and
then we don't have to require that the postinst script do this. it's no problem
if the postinst wants to do it, too.

http://codereview.chromium.org/2132008/diff/14001/15007
File src/scripts/make_factory_package.sh (right):

http://codereview.chromium.org/2132008/diff/14001/15007#newcode7
src/scripts/make_factory_package.sh:7: # Script to convert the output of
build_image.sh to a usb image.
better description?

http://codereview.chromium.org/2132008/diff/14001/15009
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/2132008/diff/14001/15009#newcode35
src/scripts/mod_image_for_test.sh:35: "The root location for board sysroots."
indent by 4

[Nick Sanders, 2010-05-18 20:45:41]

http://codereview.chromium.org/2132008/diff/14001/15004
File src/platform/installer/chromeos-postinst (right):

http://codereview.chromium.org/2132008/diff/14001/15004#newcode59
src/platform/installer/chromeos-postinst:59: # We'll fix this RSN.
On 2010/05/18 17:27:05, adlr wrote:
> you might want to add a note reminding people that code in here must work on
all
> versions of chromium os that we'll ship this update to, since it's using the
> version of gpt that shipped down w/ that image (or, in the case of factory
> install, the version on the shim).

good point, that could totally bite us later.

http://codereview.chromium.org/2132008/diff/14001/15005
File src/platform/memento_softwareupdate/memento_updater.sh (left):

http://codereview.chromium.org/2132008/diff/14001/15005#oldcode325
src/platform/memento_softwareupdate/memento_updater.sh:325: echo 3 >
/proc/sys/vm/drop_caches
On 2010/05/18 17:27:05, adlr wrote:
> we should probably keep this here, b/c it won't cause much performace drop and
> then we don't have to require that the postinst script do this. it's no
problem
> if the postinst wants to do it, too.

Done.

http://codereview.chromium.org/2132008/diff/14001/15007
File src/scripts/make_factory_package.sh (right):

http://codereview.chromium.org/2132008/diff/14001/15007#newcode7
src/scripts/make_factory_package.sh:7: # Script to convert the output of
build_image.sh to a usb image.
On 2010/05/18 17:27:05, adlr wrote:
> better description?

Done.

http://codereview.chromium.org/2132008/diff/14001/15009
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/2132008/diff/14001/15009#newcode35
src/scripts/mod_image_for_test.sh:35: "The root location for board sysroots."
On 2010/05/18 17:27:05, adlr wrote:
> indent by 4

Done. Also fixed others.

[adlr, 2010-05-18 21:17:18]

LGTM if sosa LGTMs and you fix the nits below

http://codereview.chromium.org/2132008/diff/18001/19004
File src/platform/installer/chromeos-postinst (right):

http://codereview.chromium.org/2132008/diff/18001/19004#newcode58
src/platform/installer/chromeos-postinst:58: # TODO(wfrichar): The current gpt
tool requires a -b arg to specify the PMBR bootcode. We
80 cols

http://codereview.chromium.org/2132008/diff/18001/19004#newcode63
src/platform/installer/chromeos-postinst:63: # rather than the new image. So
changes here need to be backwards compatible with
80 cols

[Nick Sanders, 2010-05-18 21:58:17]

http://codereview.chromium.org/2132008/diff/18001/19004
File src/platform/installer/chromeos-postinst (right):

http://codereview.chromium.org/2132008/diff/18001/19004#newcode58
src/platform/installer/chromeos-postinst:58: # TODO(wfrichar): The current gpt
tool requires a -b arg to specify the PMBR bootcode. We
On 2010/05/18 21:17:19, adlr wrote:
> 80 cols

Done.

http://codereview.chromium.org/2132008/diff/18001/19004#newcode63
src/platform/installer/chromeos-postinst:63: # rather than the new image. So
changes here need to be backwards compatible with
On 2010/05/18 21:17:19, adlr wrote:
> 80 cols

Done.

[Nick Sanders, 2010-05-18 22:03:55]

+cc cmasone

[sosa, 2010-05-18 22:54:44]

lgtm

[Chris Masone, 2010-05-19 00:19:43]

On 2010/05/18 22:54:44, sosa wrote:
> lgtm

the image_to_usb stuff lgtm