Issue 2131015: Add more images support for system and EC firmware.

Issue 2131015: Add more images support for system and EC firmware. (Closed)

Created:
10 years, 7 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Tammo Spalink, Nick Sanders, adlr

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/chromiumos

Visibility:
Public.

Description

Add more images support for system and EC firmware. Factory install needs to do firmware update, both system rom and EC rom. Add this support to AU server.

Patch Set 5 : self-documenting code #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -14 lines)			Patch
	M	src/platform/dev/autoupdate.py	View	1 2 3 4	3 chunks	+25 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

adlr

http://codereview.chromium.org/2131015/diff/3001/4001 File src/platform/dev/autoupdate.py (right): http://codereview.chromium.org/2131015/diff/3001/4001#newcode233 src/platform/dev/autoupdate.py:233: kind = key[:-6] can you put a comment here ...

10 years, 7 months ago (2010-05-19 14:11:36 UTC) #2

Tom Wai-Hong Tam

10 years, 7 months ago (2010-05-19 14:25:50 UTC) #3

adlr

LGTM if you make the change below http://codereview.chromium.org/2131015/diff/10001/11001 File src/platform/dev/autoupdate.py (right): http://codereview.chromium.org/2131015/diff/10001/11001#newcode233 src/platform/dev/autoupdate.py:233: # Strip ...

10 years, 7 months ago (2010-05-19 14:29:58 UTC) #4

Tom Wai-Hong Tam

10 years, 7 months ago (2010-05-19 14:41:57 UTC) #5

http://codereview.chromium.org/2131015/diff/10001/11001
File src/platform/dev/autoupdate.py (right):

http://codereview.chromium.org/2131015/diff/10001/11001#newcode233
src/platform/dev/autoupdate.py:233: # Strip the ending '_image', 6 chars.
Done. That's great, self-documenting.

Expand Messages | Collapse Messages