Issue 2131013: Fix grit unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2131013: Fix grit unittests. (Closed)

Created:
10 years, 7 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Jói

CC:
chromium-reviews

Visibility:
Public.

Description

Fix grit unittests. The two rc unittests are failing because it appears the data files checked into svn don't match. It's easier to change the tests because the data is in a different (internal only) repo. AFAICT, this has been broken forever. The other fix is because a test became more correct after r43930, but the test was passing anyway. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47756

Patch Set 1 #

Patch Set 2 : fix #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
M	tools/grit/grit/format/rc_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/grit/grit/gather/rc_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/grit/grit/tclib_unittest.py	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages