Issue 2131005: Mac: Infrastructure for serialization of OS fonts over IPC.

Issue 2131005: Mac: Infrastructure for serialization of OS fonts over IPC. (Closed)

Created:
10 years, 7 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
John Grabowski, Avi (use Gerrit)

CC:
chromium-reviews

Visibility:
Public.

Description

Mac: Infrastructure for serialization of OS fonts over IPC. BUG=29729 TEST=All unit tests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48002

Patch Set 2 : Be gone evil tabs #

Total comments: 4

Patch Set 3 : Better error logging #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+397 lines, -9 lines)			Patch
M	base/file_util.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
A	chrome/common/font_loader_mac.h	View		1 chunk	+49 lines, -0 lines	0 comments	Download
A	chrome/common/font_loader_mac.mm	View	1 2	1 chunk	+134 lines, -0 lines	0 comments	Download
A	chrome/common/font_loader_mac_unittest.mm	View		1 chunk	+50 lines, -0 lines	0 comments	Download
A +	chrome/common/sandbox_mac_diraccess_unittest.mm	View		3 chunks	+6 lines, -0 lines	0 comments	Download
A	chrome/common/sandbox_mac_fontloading_unittest.mm	View		1 chunk	+132 lines, -0 lines	0 comments	Download
M	chrome/common/sandbox_mac_unittest_helper.h	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	chrome/common/sandbox_mac_unittest_helper.mm	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jeremy

jrg: changes to Mac sandbox test infrastructure. avi: everything else.

10 years, 7 months ago (2010-05-16 12:41:36 UTC) #1

Avi (use Gerrit)

LG http://codereview.chromium.org/2131005/diff/2001/3003 File chrome/chrome_tests.gypi (right): http://codereview.chromium.org/2131005/diff/2001/3003#newcode985 chrome/chrome_tests.gypi:985: 'common/font_loader_mac_unittest.mm', indent?

10 years, 7 months ago (2010-05-17 14:43:38 UTC) #2

John Grabowski

10 years, 7 months ago (2010-05-17 22:11:11 UTC) #3

LGTM

http://codereview.chromium.org/2131005/diff/2001/3003
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/2131005/diff/2001/3003#newcode998
chrome/chrome_tests.gypi:998: 'common/sandbox_mac_diraccess_unittest.mm',
With this change you are removing common/sandbox_mac_unittest.mm from the build.
 Is that intentional?

http://codereview.chromium.org/2131005/diff/2001/3004
File chrome/common/font_loader_mac.h (right):

http://codereview.chromium.org/2131005/diff/2001/3004#newcode29
chrome/common/font_loader_mac.h:29: static bool LoadFontIntoBuffer(const
string16& font_name,
It seems font_data_size and font_data are directly associated.  Why not a
structure that contains both?

http://codereview.chromium.org/2131005/diff/2001/3005
File chrome/common/font_loader_mac.mm (right):

http://codereview.chromium.org/2131005/diff/2001/3005#newcode22
chrome/common/font_loader_mac.mm:22: *font_data_size = 0;
CHECK(font_data && font_data_size);

Expand Messages | Collapse Messages