Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 213031: Insert summary results to the JSON. These are the same results spit to stdout... (Closed)

Created:
11 years, 3 months ago by ojan
Modified:
9 years, 7 months ago
Reviewers:
tony, dglazkov
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Insert summary results to the JSON. These are the same results spit to stdout at the end of run_webkit_tests.py. This will allow dglazkov to create a dashboard tracking layout test progress. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26618

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -62 lines) Patch
M webkit/tools/layout_tests/layout_package/json_results_generator.py View 1 8 chunks +65 lines, -3 lines 0 comments Download
M webkit/tools/layout_tests/run_webkit_tests.py View 1 6 chunks +103 lines, -59 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
11 years, 3 months ago (2009-09-18 20:36:39 UTC) #1
tony
11 years, 3 months ago (2009-09-18 20:49:37 UTC) #2
LGTM

http://codereview.chromium.org/213031/diff/1/3
File webkit/tools/layout_tests/layout_package/json_results_generator.py (right):

http://codereview.chromium.org/213031/diff/1/3#newcode44
Line 44: FAILURE_CHARS = ["C", "T", "I", "S", "F", "O"]
Nit: Use () instead of [] to make it an immutable tuple instead of a list.

http://codereview.chromium.org/213031/diff/1/3#newcode244
Line 244: count = entry[char]
Nit: count = entry.get(char, 0)

Powered by Google App Engine
This is Rietveld 408576698