DescriptionFix a crash canceling a completed, auto-opened download.
To reproduce this crash:
1. Set 'Always open files of this type' on the download shelf
menu to checked for a particular file type.
2. Download a large file of that type.
3. Before the download completes, open its context menu on
the shelf.
4. When the download completes, select 'Cancel' from the menu.
5. Crash.
The crash occurs because auto-opened downloads automatically
remove (and thus delete) themselves from the shelf even if
the menu is still running. Selecting a menu item at this point
will attempt to access the deleted object.
The fix is to let the menu know when the calling object is
becoming invalid, so we can avoid doing any further work.
BUG=20810
TEST=Try the above repro steps and notice that Chrome doesn't crash.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26589
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|