Issue 213017: Moving two http utility functions to a separate source file due to dependency...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213017: Moving two http utility functions to a separate source file due to dependency... (Closed)

Created:
11 years, 3 months ago by tommi (sloooow) - chröme

Modified:
9 years, 7 months ago

Reviewers:
slightlyoff, amit, darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Moving two http utility functions to a separate source file due to dependency on icu. This allows usage of e.g. HeadersIterator without pulling in all of icu. TEST=no code change. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26545

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -16 lines)			Patch
M	net/http/http_util.cc	View	1	3 chunks	+2 lines, -16 lines	0 comments	Download
A	net/http/http_util_icu.cc	View		1 chunk	+30 lines, -0 lines	2 comments	Download
M	net/net.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

http://codereview.chromium.org/213017/diff/2001/3002 File net/http/http_util_icu.cc (right): http://codereview.chromium.org/213017/diff/2001/3002#newcode1 Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All ...

11 years, 3 months ago (2009-09-18 04:29:14 UTC) #4

tommi (sloooow) - chröme

11 years, 3 months ago (2009-09-18 05:30:03 UTC) #5

thanks darin - comments addressed in http://codereview.chromium.org/216021

Expand Messages | Collapse Messages