Issue 213011: WebKit merge 49483:49491...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213011: WebKit merge 49483:49491... (Closed)

Created:
11 years, 3 months ago by Nate Chapin

Modified:
9 years, 5 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

WebKit merge 49483:49491 BUG=10408 BUG=10409 BUG=10675 BUG=14091 BUG=18939 BUG=20987 BUG=21136 TEST=Green bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26515

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 3

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -31 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/tools/layout_tests/test_expectations.txt	View		10 chunks	+3 lines, -30 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dglazkov

11 years, 3 months ago (2009-09-17 22:29:10 UTC) #2

LGTM, except:

http://codereview.chromium.org/213011/diff/2001/2003
File webkit/tools/layout_tests/test_expectations.txt (left):

http://codereview.chromium.org/213011/diff/2001/2003#oldcode2274
Line 2274: BUG14091 :
LayoutTests/fast/dom/DOMImplementation/detached-doctype.html = CRASH
I removed this first! :)

http://codereview.chromium.org/213011/diff/2001/2003#oldcode2324
Line 2324: BUG21919 WIN :
LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame.html =
FAIL
This too!

http://codereview.chromium.org/213011/diff/2001/2003#oldcode2338
Line 2338: BUG_DGLAZKOV : LayoutTests/fast/dom/doctype-event-listener-crash.html
= CRASH
Hmm.. That too.

Expand Messages | Collapse Messages