Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6343)

Unified Diff: chrome/common/extensions/extension_unittest.cc

Issue 213009: Fix bug where we fail to install an extension that has an empty (Closed)
Patch Set: fix tests Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_constants.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_unittest.cc
diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc
index fb40330e0f93ee172b7b698a761c29c111f2d55f..564ef0c6c5c0f312f22da50b34c0aae6f948da75 100644
--- a/chrome/common/extensions/extension_unittest.cc
+++ b/chrome/common/extensions/extension_unittest.cc
@@ -182,11 +182,7 @@ TEST(ExtensionTest, InitFromValueInvalid) {
permissions = new ListValue;
input_value->Set(keys::kPermissions, permissions);
EXPECT_TRUE(extension.InitFromValue(*input_value, true, &error));
- const std::vector<std::string>* error_vector =
- ExtensionErrorReporter::GetInstance()->GetErrors();
- const std::string log_error = error_vector->at(error_vector->size() - 1);
- EXPECT_TRUE(MatchPattern(log_error,
- errors::kInvalidPermissionCountWarning));
+ EXPECT_EQ(0u, ExtensionErrorReporter::GetInstance()->GetErrors()->size());
input_value->Set(keys::kPermissions, Value::CreateIntegerValue(9));
EXPECT_FALSE(extension.InitFromValue(*input_value, true, &error));
« no previous file with comments | « chrome/common/extensions/extension_constants.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698