Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: chrome/common/extensions/extension_constants.cc

Issue 213009: Fix bug where we fail to install an extension that has an empty (Closed)
Patch Set: fix tests Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_constants.h" 5 #include "chrome/common/extensions/extension_constants.h"
6 6
7 namespace extension_manifest_keys { 7 namespace extension_manifest_keys {
8 8
9 const wchar_t* kBackground = L"background_page"; 9 const wchar_t* kBackground = L"background_page";
10 const wchar_t* kChromeURLOverrides = L"chrome_url_overrides"; 10 const wchar_t* kChromeURLOverrides = L"chrome_url_overrides";
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 const char* kInvalidPageActionsList = 93 const char* kInvalidPageActionsList =
94 "Invalid value for 'page_actions'."; 94 "Invalid value for 'page_actions'.";
95 const char* kInvalidPageActionIconPaths = 95 const char* kInvalidPageActionIconPaths =
96 "Required value 'page_actions[*].icons' is missing or invalid."; 96 "Required value 'page_actions[*].icons' is missing or invalid.";
97 const char* kInvalidPageActionId = 97 const char* kInvalidPageActionId =
98 "Required value 'id' is missing or invalid."; 98 "Required value 'id' is missing or invalid.";
99 const char* kInvalidPageActionTypeValue = 99 const char* kInvalidPageActionTypeValue =
100 "Invalid value for 'page_actions[*].type', expected 'tab' or 'permanent'."; 100 "Invalid value for 'page_actions[*].type', expected 'tab' or 'permanent'.";
101 const char* kInvalidPermissions = 101 const char* kInvalidPermissions =
102 "Required value 'permissions' is missing or invalid."; 102 "Required value 'permissions' is missing or invalid.";
103 const char* kInvalidPermissionCountWarning =
104 "Warning, 'permissions' key found, but array is empty.";
105 const char* kInvalidPermission = 103 const char* kInvalidPermission =
106 "Invalid value for 'permissions[*]'."; 104 "Invalid value for 'permissions[*]'.";
107 const char* kInvalidPermissionScheme = 105 const char* kInvalidPermissionScheme =
108 "Invalid scheme for 'permissions[*]'. Only 'http' and 'https' are " 106 "Invalid scheme for 'permissions[*]'. Only 'http' and 'https' are "
109 "allowed."; 107 "allowed.";
110 const char* kInvalidPlugins = 108 const char* kInvalidPlugins =
111 "Invalid value for 'plugins'."; 109 "Invalid value for 'plugins'.";
112 const char* kInvalidPluginsPath = 110 const char* kInvalidPluginsPath =
113 "Invalid value for 'plugins[*].path'."; 111 "Invalid value for 'plugins[*].path'.";
114 const char* kInvalidPluginsPublic = 112 const char* kInvalidPluginsPublic =
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 "Invalid value for update url: '[*]'."; 146 "Invalid value for update url: '[*]'.";
149 const char* kInvalidDefaultLocale = 147 const char* kInvalidDefaultLocale =
150 "Invalid value for default locale - locale name must be a string."; 148 "Invalid value for default locale - locale name must be a string.";
151 const char* kThemesCannotContainExtensions = 149 const char* kThemesCannotContainExtensions =
152 "A theme cannot contain extensions code."; 150 "A theme cannot contain extensions code.";
153 const char* kLocalesNoDefaultLocaleSpecified = 151 const char* kLocalesNoDefaultLocaleSpecified =
154 "Localization used, but default_locale wasn't specified in the manifest."; 152 "Localization used, but default_locale wasn't specified in the manifest.";
155 const char* kLocalesNoValidLocaleNamesListed = 153 const char* kLocalesNoValidLocaleNamesListed =
156 "No valid locale name could be found in _locales directory."; 154 "No valid locale name could be found in _locales directory.";
157 } // namespace extension_manifest_errors 155 } // namespace extension_manifest_errors
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698