Issue 213004: Modify git-try so that when files are added, it munges...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213004: Modify git-try so that when files are added, it munges... (Closed)

Created:
11 years, 3 months ago by John Gregg

Modified:
9 years ago

Reviewers:

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Description

Modify git-try so that when files are added, it munges --- /dev/null +++ path/to/new/file into --- src/path/to/new/file +++ src/path/to/new/file as opposed to --- path/to/new/file +++ src/path/to/new/file as it is currently doing. checked in r26452

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	git-try	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Gregg

I was asking on IRC about a failed try job which turned out to be ...

11 years, 3 months ago (2009-09-17 03:08:03 UTC) #1

M-A Ruel

11 years, 3 months ago (2009-09-17 11:16:11 UTC) #3

lgtm with fix

http://codereview.chromium.org/213004/diff/1/2
File git-try (right):

http://codereview.chromium.org/213004/diff/1/2#newcode65
Line 65: def GetMungedDiff(branch):
While at it, can you make 'src' value a function parameter and make 'src' the
default function value so you don't have to fix the callers for now.

Expand Messages | Collapse Messages